From: Dan Marsden <dan@danmarsden.com>
Date: Thu, 4 May 2017 08:19:45 +0000 (+1200)
Subject: Fix #259 undefined property warnings when showing temp users.
X-Git-Url: http://git.cameron1729.xyz/?a=commitdiff_plain;h=6f057052f2b1eb457f083c2aa2be94d4d77cdc76;p=moodle-mod_attendance.git

Fix #259 undefined property warnings when showing temp users.
---

diff --git a/classes/structure.php b/classes/structure.php
index 8efdf29..6d02fa1 100644
--- a/classes/structure.php
+++ b/classes/structure.php
@@ -755,6 +755,8 @@ class mod_attendance_structure {
      * @return object
      */
     protected static function tempuser_to_user($tempuser) {
+        global $CFG;
+
         $ret = (object)array(
             'id' => $tempuser->studentid,
             'firstname' => $tempuser->fullname,
@@ -766,11 +768,17 @@ class mod_attendance_structure {
             'picture' => 0,
             'type' => 'temporary',
         );
-        foreach (get_all_user_name_fields() as $namefield) {
+        $allfields = get_all_user_name_fields();
+        if (!empty($CFG->showuseridentity)) {
+            $allfields =  array_merge($allfields, explode(',', $CFG->showuseridentity));
+        }
+
+        foreach ($allfields as $namefield) {
             if (!isset($ret->$namefield)) {
                 $ret->$namefield = '';
             }
         }
+
         return $ret;
     }