From: Frederic Massart <fred@moodle.com>
Date: Tue, 6 May 2014 06:11:30 +0000 (+0800)
Subject: Git fetch returns false when failed
X-Git-Tag: v1.2~12
X-Git-Url: https://git.cameron1729.xyz/?a=commitdiff_plain;h=785893dc8c031a0981d7a0554ff27baaf4c73cba;p=mdk.git

Git fetch returns false when failed
---

diff --git a/lib/fetch.py b/lib/fetch.py
index b253ec0..d9640e2 100644
--- a/lib/fetch.py
+++ b/lib/fetch.py
@@ -59,7 +59,7 @@ class Fetch(object):
         git = self.M.git()
         logging.info('Fetching %s from %s' % (self.ref, self.repo))
         result = git.fetch(remote=self.repo, ref=self.ref)
-        if result[0] != 0:
+        if not result:
             raise FetchException('Error while fetching %s from %s' % (self.ref, self.repo))
 
     def _merge(self):
diff --git a/lib/git.py b/lib/git.py
index d3733e3..ac89158 100644
--- a/lib/git.py
+++ b/lib/git.py
@@ -144,7 +144,8 @@ class Git(object):
 
     def fetch(self, remote='', ref=''):
         cmd = 'fetch %s %s' % (remote, ref)
-        return self.execute(cmd)
+        result = self.execute(cmd)
+        return result[0] == 0
 
     def getConfig(self, name):
         cmd = 'config --get %s' % name