https://github.com/danmarsden/moodle-mod_attendance/issues/234 (#235)

* https://github.com/danmarsden/moodle-mod_attendance/issues/234

I only found 3 files with this error:

add_form.php:   121
renderer.php:   809
sessions.php:   240

This was branched off of the MOODLE_30_STABLE branch.

* Forgot space in if() statement

diff --git a/add_form.php b/add_form.php
index d69dfa0..cfbaa87 100644 (file)
--- a/add_form.php
+++ b/add_form.php
@@ -118,7 +118,8 @@ class mod_attendance_add_form extends moodleform {
         }
 
         // Students can mark own attendance.
-        if (!empty(get_config('attendance', 'studentscanmark'))) {
+        $configcanmark = get_config('attendance', 'studentscanmark');
+        if (!empty($configcanmark)) {
             $mform->addElement('checkbox', 'studentscanmark', '', get_string('studentscanmark', 'attendance'));
             $mform->addHelpButton('studentscanmark', 'studentscanmark', 'attendance');
         } else {

diff --git a/renderer.php b/renderer.php
index 263ec34..f8fdce6 100644 (file)
--- a/renderer.php
+++ b/renderer.php
@@ -806,7 +806,8 @@ class mod_attendance_renderer extends plugin_renderer_base {
                 $cell->colspan = 2;
                 $row->cells[] = $cell;
             } else {
-                if (!empty(get_config('attendance', 'studentscanmark')) && !empty($sess->studentscanmark)) {
+                $configjs = get_config('attendance', 'studentscanmark');
+                if (!empty($configjs) && !empty($sess->studentscanmark)) {
                     // Student can mark their own attendance.
                     // URL to the page that lets the student modify their attendance.
                     $url = new moodle_url('/mod/attendance/attendance.php',

diff --git a/sessions.php b/sessions.php
index ee52e1b..3709be8 100644 (file)
--- a/sessions.php
+++ b/sessions.php
@@ -237,7 +237,8 @@ function construct_sessions_data_for_add($formdata) {
     $duration = $sesendtime - $sesstarttime;
     $now = time();
 
-    if (empty(get_config('attendance', 'studentscanmark'))) {
+    $configcanmark = get_config('attendance', 'studentscanmark');
+    if (empty($configcanmark)) {
         $formdata->studentscanmark = 0;
     }